Re: [libvirt] [PATCH] Don't use enums in TPM struct fields
On Wed, Jun 06, 2018 at 08:32:39PM +0200, Ján Tomko wrote:
This deprives us of the -Wswitch-enum warning on all compilers
because some don't detect the bogus negative value comparison.
And the comment has even less power than the clang warning. So:
1. Is it actually worth the trouble to store enum values in
typedef'd enums?
2. If so, can we make TypeFromString usage less cumbersome?
We could add a explicit
VIR_XXXXX_INVALID = -1,
entry to every single enum, which will force the compiler to
always use a signed int for representing the enum.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|