Re: [libvirt] [PATCH] qemu: add support for -device pvpanic
On 11/27/2013 03:39 AM, Peter Krempa wrote:
On 11/27/13 09:41, Hu Tao wrote:
> qemu removes the builtin pvpanic device for all qemu versions since 1.7,
> in order to support <on_crash>, '-device pvpanic' has to be added to
> qemu command line.
>
> Signed-off-by: Hu Tao <hutao(a)cn.fujitsu.com>
> ---
I remember discussions saying that it's NOT a good idea to enable
this
stuff always. As a result, this device is not being added by qemu as you
described above. Shouldn't we only add this if the user enables
<on_crash> actions?
You are precisely right; we MUST add a new entry under <devices> in the
<domain> XML before enabling this device.
See these threads for some ideas (although recall that qemu has been
fixed in the meantime to state that any distro shipping a qemu with
pvpanic enabled by default can be considered buggy, and that libvirt can
now assume that pvpanic will not happen without an explicit '-device
pvpanic'):
https://www.redhat.com/archives/libvir-list/2013-August/msg01184.html
https://www.redhat.com/archives/libvir-list/2013-August/msg01136.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)