Re: [libvirt PATCH 01/11] qemu_snapshot: revert: always error out if VM XML is missing
On Mon, Nov 15, 2021 at 17:22:44 +0100, Pavel Hrdina wrote:
The support to revert snapshots was introduced in libvirt 0.8.0 but
saving the whole VM XML was implemented later in libvirt 0.9.5.
That is more then 10 years ago so we can safely assume that nobody will
try reverting to snapshot created by that old libvirt. In the unlikely
scenario where someone would actually did it we would simply error out.
In addition we don't even support QEMUs which were around at that time,
so with reasonable configuration this will not be a problem because such
old libvirt on the other hand wouldn't be able to drive new qemus.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/qemu/qemu_snapshot.c | 138 +++++++++++++++++++--------------------
1 file changed, 66 insertions(+), 72 deletions(-)
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>