Re: [libvirt] [PATCH 5/6] snapshot: new virsh function factored from snapshot-list

On 06/09/12 06:34, Eric Blake wrote: > This patch copies just the fallback code out of cmdSnapshotList, > and keeps the snapshot objects around rather than just their > name for easier manipulation. It looks forward to a future > patch when we add a way to list all snapshot objects at once, > and the next patch will simplify cmdSnapshotList to take > advantage of this factorization. >

I know it's copied code, but this error message doesn't look helpful. I think it's worth improving: "Failed to collect snapshot list" perhaps? > + goto cleanup; > + } I had a very hard time parsing the code flow in this block, I'd rewrite this block as follows: