Re: [libvirt] [PATCH 2/4] Convert libvirtd over to the new RPC handling APIs

On 06/27/2011 08:24 AM, Daniel P. Berrange wrote: > This guts the libvirtd daemon, removing all its networking and > RPC handling code. Instead it calls out to the new virServerPtr > APIs for all its RPC & networking work > > As a fallout all libvirtd daemon error reporting now takes place > via the normal internal error reporting APIs. There is no need > to call separate error reporting APIs in RPC code, nor should > code use VIR_WARN/VIR_ERROR for reporting fatal problems anymore. > > * daemon/qemu_dispatch_*.h, daemon/remote_dispatch_*.h: Remove > old generated dispatcher code > * daemon/qemu_dispatch.h, daemon/remote_dispatch.h: New dispatch > code > * daemon/dispatch.c, daemon/dispatch.h: Remove obsoleted code > * daemon/remote.c, daemon/remote.h: Rewrite for new dispatch > APIs > * daemon/libvirtd.c, daemon/libvirtd.h: Remove all networking > code > * daemon/stream.c, daemon/stream.h: Update for new APIs > * daemon/Makefile.am: Link to libvirt-net-rpc-server.la > +++ b/daemon/Makefile.am > @@ -3,33 +3,21 @@ > CLEANFILES =

> +++ b/daemon/libvirtd.c > @@ -23,31 +23,13 @@ > > #include <grp.h> > -#include <signal.h> > -#include <netdb.h> > -#include <locale.h> A bit too prune-happy; compilation failed. And even then, I'm getting a test failure: 31) corrupted config audit_logging ... OK ./daemon-conf: line 98: kill: (22788) - No such process 32) valid config file (sleeping 2 seconds) ... FAILED FAIL: daemon-conf