Re: [libvirt] [PATCH 15/16] snapshot: Tweaks to support new bulk dumpxml/import API

On 3/20/19 1:41 AM, Eric Blake wrote: > Change the return value of virDomainSnapshotObjLisParse() to return *ListParse > the number of snapshots imported, and allow a return of 0 (the > original proposal of adding a flag to virDomainSnapshotCreateXML > required returning an arbitrary non-NULL snapshot, but with a new API > that returns a count, we are no longer constrained to a non-empty > list). > > Document which flags are supported (namely, just SECURE) in > virDomainSnapshotObjListFormat(). > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/conf/virdomainsnapshotobjlist.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > Perhaps 2 separate patches since I don't think they're related.

Reviewed-by: John Ferlan <jferlan(a)redhat.com&gt; John