Re: [libvirt] [PATCH v2] Check for --no-copy-dt-needed linker flag

>> + NO_INDIRECT_LDFLAGS= >> + `$LD --help 2>&1 | grep -- "--no-copy-dt-needed-entries" >/dev/null` && \ > > Doesn't do what you think (it tries to execute the output of grep - > which is thankfully empty on both success and failure). Also wastes a > fork on grep, compared to the simpler: I was looking following virt-linker-relro.m4 and I'm getting the correct result since the output is always empty but for the non matching case grep exits with 1. However > > case `$LD --help 2>&1` in > *--no-copy-dt-needed-entries*) NO_INDIRECT_LDFLAGS=... ;; > esac this looks nicer.

> Why aren't you building this directly into $(AM_LDFLAGS) once, rather > than having to copy it into each and every library recipe? > > Why only src/ and tests/? What about tools/ and daemon/? Again following the above example. I'll come up with a v3.