Re: [Libvir] [PATCH] add bootloader_args to libvirt xml to support bootloaders (like pypxeboot for example) that require arguments
On Mon, Jun 04, 2007 at 05:08:14PM -0400, Hugh Brock wrote:
This patch extends libvirt's XML to include a paramater Xen
already
supports in sexpr, "bootloader_args." The bootloader_args parameter lets
you pass arguments -- "mac=aa:12:34:56:78:90" for example -- to a
bootloader program that xend invokes when it starts a guest. One such
program, pypxeboot, uses the mac= argument to communicate with a dhcp
server and retrieve the pxeboot kernel and initrd for a paravirt guest.
The patch includes new tests for the bootloader_args XML and sexpr,
which pass.
Note that for the head of current libvirt, the virsh tests do not pass
and virsh will not connect to the xen hypervisor. I don't know if this
is my own build environment or some other issue. However the failure is
the same with or without this patch, so I am submitting it anyway.
Please let me know what you think...
This all looks simple and clear except one point.
We used to process pygrub differently than other bootloaders, basically testing
for that value and making it a special case, ending up with 3 different case:
- no bootloader (bootloader == 0)
- bootloader is not pygrub (bootloader == 1)
- bootloader is pygrub (bootloader == 2)
I'm pretty sure we made that on purpose to avoid some problem, but I can't
remember why :-(. Your patch changes that and gets back to only 2 case, and
I don't see an explanation of what changed to drop the special case. Can
you explain why this was changed ? I also wonder what would happen if we drop
the new libvirt resulting from this say on a Fedora Core 6, would that break
pygrub in that environment due to the change ?
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/