Re: [libvirt] [PATCH v4] virsh: avoid missing zero value judgement in cmdBlkiotune
On 07/28/2011 08:25 AM, ajia wrote:
>> - _("Unable to parse integer parameter"));
>> + _("Unable to parse non-integer parameter"));
> Why this change?
when I give a non-integer to weight value such as
virsh blkiotune $domain --weight demo, vshError will be hit and raise
"Unable to parse integer parameter", 'demo' is a string not integer,
it
should
be only can parse integer parameter, so I think it should be changed
like above,
please correct me again if I'm wrong again.
If you wanted to do that, then we need something longer:
Unable to parse, non-integer encountered where integer parameter expected
But I think the shorter version is accurate - our intent is to tell the
user "this option requires an integer parameter, but the input you gave
me could not be parsed as an integer".
So I don't think the error message should change.
BTW, except this, are others okay?
Yes, so I pushed with that one line fixed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org