Re: [libvirt] [RFC PATCH v3 4/9] qemu: Add capabilities for optional pSeries features
On Tue, 2018-03-06 at 11:26 +0530, Shivaprasad bhat wrote:
[...]
On the contrary, I see query device-list-proprties on spapr-machine
results in CapsProbeFailure. I tried on both v2.11.1 and v.2.10.2
2018-03-06 05:41:16.201+0000: 119127: error : qemuMonitorJSONCheckError:392 : internal
error: unable to execute QEMU command 'device-list-properties':
Parameter
'typename' expects device
2018-03-06 05:41:16.201+0000: 119127: warning :
virQEMUCapsLogProbeFailure:5241 : Failed to probe capabilities for /usr/libexec/qemu-kvm:
internal error:
unable to execute QEMU command 'device-list-properties':
Parameter 'typename' expects device
[...]
Also because of that, I think we should query machine features only
if
QEMU_CAPS_QOM_LIST_PROPERTIES is there.
Aw, fish.
I should have done this myself instead of relying on assumptions
that turned out not to hold up. Thanks for spotting the problem,
I'll try to figure out something :)
--
Andrea Bolognani / Red Hat / Virtualization