Re: [libvirt] [PATCH] Fix virInterfaceIpDefPtr leak during virInterfaceIpDefFree().

On Mon, Nov 02, 2009 at 08:34:50AM -0500, Laine Stump wrote: > This is the only update to the patchset already sent. All other problems > were either in netcf code, or will be cleaned up later. > > A patch has been sent to netcf-devel which, when applied, allows make > check of libvirt plus the patch series to complete with no errors. > > There is still one issue, affecting bond interfaces, which is not > revealed by make check. I'll describe that in a separate email. > --- > src/conf/interface_conf.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c > index fc18eba..31af957 100644 > --- a/src/conf/interface_conf.c > +++ b/src/conf/interface_conf.c > @@ -58,6 +58,7 @@ void virInterfaceIpDefFree(virInterfaceIpDefPtr def) { > if (def == NULL) > return; > VIR_FREE(def->address); > + VIR_FREE(def); > } > Okay, applied ! I have the single netcf patch to avoid a crash, but when running the regression tests I still see: 9) Interface XML-2-XML bond ... FAILED 10) Interface XML-2-XML bond-arp ... FAILED FAIL: interfacexml2xmltest ===================== 12 of 43 tests failed ===================== make[3]: *** [check-TESTS] Error 1 So what am I missing ?