Re: [libvirt] [PATCH v3 27/34] Adapt to VIR_STRDUP and VIR_STRNDUP in src/vmware/*
On 15.05.2013 23:23, Matthias Bolte wrote:
2013/5/3 Michal Privoznik <mprivozn(a)redhat.com>:
> ---
> src/vmware/vmware_conf.c | 28 ++++++++++------------------
> src/vmware/vmware_driver.c | 11 +++++------
> 2 files changed, 15 insertions(+), 24 deletions(-)
>
> diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c
> index 4fb61a8..4b61a9c 100644
> --- a/src/vmware/vmware_conf.c
> +++ b/src/vmware/vmware_conf.c
> @@ -492,12 +488,8 @@ cleanup:
> char *
> vmwareCopyVMXFileName(const char *datastorePath, void *opaque ATTRIBUTE_UNUSED)
> {
> - char *path = strdup(datastorePath);
> -
> - if (path == NULL) {
> - virReportOOMError();
> - return NULL;
> - }
> + char *path;
>
> + ignore_value(VIR_STRDUP_QUIET(path, datastorePath));
> return path;
> }
Why did you remove the OOM reporting here?
--
Matthias Bolte
http://photron.blogspot.com
Wooops, can you send a patch please?
Michal