Re: [libvirt] [PATCH V13 2/5] nwfilter: add DHCP snooping
On 05/01/2012 08:04 AM, Stefan Berger wrote:
> I've run out of review time today. Here's what I had to
add to get
> 'make syntax-check' to be happy, but there are a lot of other cleanups
> I've mentioned above.
>
>
Thanks for the review so far. I would have caught the make syntax-check
stuff myself, but unfortunately it doesn't seem to look into the directory.
Odd, because it worked for me. Maybe what happened is that you ran
'make syntax-check' before actually doing a 'git add' of the new file;
the syntax check rules ask git to list which files are checked in, and
if it is a new file, not checked in yet at the time you run the syntax
check, then that would explain why none of the checks fire at that point
in time.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)