Re: [libvirt] [PATCH v4 10/13] Implement driver interface domainSetMemoryParamters for LXC

On Tue, 12 Oct 2010 18:32:19 +0200, Daniel Veillard <veillard(a)redhat.com&gt; wrote: > On Fri, Oct 08, 2010 at 05:46:28PM +0530, Nikunj A. Dadhania wrote: > > From: Nikunj A. Dadhania <nikunj(a)linux.vnet.ibm.com&gt; > > > > Add support in the lxc driver for various memory controllable parameters > > > > v4: > > + prototype change: add unsigned int flags > > > > v2: > > + Use #define string constants for "hard_limit", etc > > + fix typo: min_guarantee > > > > Acked-by: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > > Signed-off-by: Nikunj A. Dadhania <nikunj(a)linux.vnet.ibm.com&gt; [...] > > + if (vm == NULL) { > > + char uuidstr[VIR_UUID_STRING_BUFLEN]; > > + virUUIDFormat(dom->uuid, uuidstr); > > + lxcError(VIR_ERR_NO_DOMAIN, > > + _("No domain with matching uuid '%s'"), uuidstr); > > + goto cleanup; > > + } > > Hum, the qemu driver was reporting > > if (vm == NULL) { > qemuReportError(VIR_ERR_INTERNAL_ERROR, > _("No such domain %s"), dom->uuid); > goto cleanup; > } > > the 2 should be harmonized I guess, but since the LXC reporting is better > I left this as a TODO, seems that's a more general cleanup needed between > drivers. > Let me look at this and I will provide a patch.

> Same problem of error reporting as in the QEmu driver, I moved ret = 0; > before the loop and et ret = -1; on all errors ! > One clarification: Will it return error back immediately if an error occurs?

Or will it try setting all of them one by one and if anyone of them succeed, success is returned.