Re: [libvirt] [PATCH 1/8] Define a QEMU specific API to attach to a running QEMU process
On Fri, Jul 08, 2011 at 02:52:36PM -0600, Eric Blake wrote:
On 07/04/2011 04:28 AM, Daniel P. Berrange wrote:
> Introduce a new API in libvirt-qemu.so
>
> virDomainPtr virDomainQemuAttach(virConnectPtr domain,
> unsigned long long pid,
We already assert elsewhere in our code base that pid_t will always fit
in int. For example, see _virDomainObj in domain_conf.h. Passing a ull
here seems like it might be overkill.
Last time I posted this series there was some question whether we'd be
ok with just 'unsigned int pid', so I changed to long long. I can
change it back again trivially though if we think unsigned int will
in face be safe.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|