Re: [libvirt] [PATCH] virsh: Improve editing

On Fri, May 13, 2011 at 12:34:25 +0200, Michal Privoznik wrote: > When users (pool-/net-)edit and they make a mistake, temporary file > and thus all changes are gone. Better way is to let them decide if > they want to get back to edit and correct what's wrong. > However, this is suitable only in interactive mode. > --- > tools/virsh.c | 42 ++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 40 insertions(+), 2 deletions(-) I like the idea (not sure if that's because I suggested it :-P) but, I have a few comments. The patch doesn't touch iface-edit, which is not generated from cmdEdit, though the right fix might turn out to be generating cmdIfaceEdit together with cmdPoolEdit and cmdNetworkEdit. And IMHO *edit commands are always interactive even when not called in virsh interactive mode so I'd prefer this behaviour to be unconditional. I can't imagine anyone sane to call virsh edit from a script, it's much easier to just call virsh dumpxml, change the xml and virsh define it back.