11:32 a.m.
On Sat, 2014-05-17 at 07:20 +0100, xen.org wrote:
flight 26326 libvirt real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/26326/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-amd64-libvirt 4 libvirt-build fail REGR. vs. 26314
build-armhf-libvirt 4 libvirt-build fail REGR. vs. 26314
build-i386-libvirt 4 libvirt-build fail REGR. vs. 26314
This is:
conf/domain_conf.c: In function 'virDomainDiskSourceParse':
conf/domain_conf.c:4992:9: error: comparison of unsigned expression < 0 is
always false [-Werror=type-limits]
conf/domain_conf.c:5015:21: error: comparison of unsigned expression < 0 is
always false [-Werror=type-limits]
conf/domain_conf.c: In function 'virDomainDiskBackingStoreParse':
conf/domain_conf.c:5113:5: error: comparison of unsigned expression < 0 is
always false [-Werror=type-limits]
(from
http://www.chiark.greenend.org.uk/~xensrcts/logs/26326/build-amd64-libvir...
)
I think this isn't Xen specific. I had a look at the recent traffic on
libvir-list and didn't see anything related so forwarding to
libvirt-list and Eric who seems to have touched the file in question in
the range.
Ian.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 1 xen-build-check(1) blocked n/a
test-armhf-armhf-libvirt 1 xen-build-check(1) blocked n/a
test-amd64-i386-libvirt 1 xen-build-check(1) blocked n/a
version targeted for testing:
libvirt d18aa7041699343d4df01cd9352e24f215b08c21
baseline version:
libvirt 5099084eb30c9c5454e79e8eab8bcff038c0f8cd
------------------------------------------------------------
People who touched revisions under test:
Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
Eric Blake <eblake(a)redhat.com>
Jiri Denemark <jdenemar(a)redhat.com>
Michal Privoznik <mprivozn(a)redhat.com>
------------------------------------------------------------
jobs:
build-amd64 pass
build-armhf pass
build-i386 pass
build-amd64-libvirt fail
build-armhf-libvirt fail
build-i386-libvirt fail
build-amd64-oldkern pass
build-i386-oldkern pass
build-amd64-pvops pass
build-armhf-pvops pass
build-i386-pvops pass
test-amd64-amd64-libvirt blocked
test-armhf-armhf-libvirt blocked
test-amd64-i386-libvirt blocked
------------------------------------------------------------
sg-report-flight on osstest.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
------------------------------------------------------------
commit d18aa7041699343d4df01cd9352e24f215b08c21
Author: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
Date: Tue May 13 16:01:16 2014 +0800
util: fix memory leak in failure path of virCgroupKillRecursiveInternal
Don't leak keypath when we fail to kill a process
Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
commit b279e52f7bd07dfe6e7f5ef0b34f2b424c50eee2
Author: Eric Blake <eblake(a)redhat.com>
Date: Wed May 14 16:40:33 2014 -0600
maint: prefer enum over int for virstoragefile structs
For internal structs, we might as well be type-safe and let the
compiler help us with less typing required on our part (getting
rid of casts is always nice). In trying to use enums directly,
I noticed two problems in virstoragefile.h that can't be fixed
without more invasive refactoring: virStorageSource.format is
used as more of a union of multiple enums in storage volume
code (so it has to remain an int), and virStorageSourcePoolDef
refers to pooltype whose enum is declared in src/conf, but where
src/util can't pull in headers from src/conf.
* src/util/virstoragefile.h (virStorageNetHostDef)
(virStorageSourcePoolDef, virStorageSource): Use enums instead of
int for fields of internal types.
* src/qemu/qemu_command.c (qemuParseCommandLine): Cover all values.
* src/conf/domain_conf.c (virDomainDiskSourceParse)
(virDomainDiskSourceFormat): Simplify clients.
* src/qemu/qemu_driver.c
(qemuDomainSnapshotCreateSingleDiskActive)
(qemuDomainSnapshotPrepareDiskExternalBackingInactive)
(qemuDomainSnapshotPrepareDiskExternalOverlayActive)
(qemuDomainSnapshotPrepareDiskInternal): Likewise.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
commit ab5178188f250385132338e004d5c1f160fc5f34
Author: Eric Blake <eblake(a)redhat.com>
Date: Wed May 14 13:48:15 2014 -0600
maint: shorten 'TypeType' function names
The VIR_ENUM_DECL/VIR_ENUM_IMPL helper macros already append 'Type'
to the enum name being converted; it looks silly to have functions
with 'TypeType' in their name. Even though some of our enums have
to have a 'Type' suffix, the corresponding string conversion
functions do not.
* src/conf/secret_conf.h (VIR_ENUM_DECL): Rename virSecretUsageType.
* src/conf/storage_conf.h (VIR_ENUM_DECL): Rename
virStoragePoolAuthType, virStoragePoolSourceAdapterType,
virStoragePartedFsType.
* src/conf/domain_conf.c (virDomainDiskDefParseXML)
(virDomainFSDefParseXML, virDomainFSDefFormat): Update callers.
* src/conf/secret_conf.c (virSecretDefParseUsage)
(virSecretDefFormatUsage): Likewise.
* src/conf/storage_conf.c (virStoragePoolDefParseAuth)
(virStoragePoolDefParseSource, virStoragePoolSourceFormat):
Likewise.
* src/lxc/lxc_controller.c (virLXCControllerSetupLoopDevices):
Likewise.
* src/storage/storage_backend_disk.c
(virStorageBackendDiskPartFormat): Likewise.
* src/util/virstorageencryption.c (virStorageEncryptionSecretParse)
(virStorageEncryptionSecretFormat): Likewise.
* tools/virsh-secret.c (cmdSecretList): Likewise.
* src/libvirt_private.syms (secret_conf.h, storage_conf.h): Export
corrected names.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
commit ea18f8b2b0337acfa418080d73035fac2185850b
Author: Eric Blake <eblake(a)redhat.com>
Date: Wed May 14 13:36:56 2014 -0600
maint: use enum typedef for virstorageencryption.h
Continuing the work of consistent enum cleanups; this time in
virstorageencryption.h.
* src/util/virstorageencryption.h (virStorageEncryptionFormat):
Convert to typedef, renaming to avoid collision with function.
(virStorageEncryptionSecret, virStorageEncryption): Directly use
enums.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
commit 3e44cf7fc60cdb45b899085b9c9c1eb1adafd097
Author: Eric Blake <eblake(a)redhat.com>
Date: Wed May 14 13:26:28 2014 -0600
vbox: fix stale comment about vdi storage type
The code had some todo's about adding 'vdi' to the list of
virStorageType, but we've already done that.
* src/vbox/vbox_tmpl.c (vboxStorageVolCreateXML)
(vboxStorageVolGetXMLDesc): Use enum value for vdi type.
Signed-off-by: Eric Blake <eblake(a)redhat.com>
commit 6f9c75a6f7cbd18eea6c6d4df9ba74f9ddddcff6
Author: Michal Privoznik <mprivozn(a)redhat.com>
Date: Wed Apr 2 19:05:42 2014 +0200
qemu: Implement virDomain{Get,Set}Time
One caveat though, qemu-ga is expecting time and returning time
in nanoseconds. With all the buffering and propagation delay, the
time is already wrong once it gets to the qemu-ga, but there's
nothing we can do about it.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
commit 222fdbfd2b852bd47d976a6305cc5cf4849824e0
Author: Michal Privoznik <mprivozn(a)redhat.com>
Date: Wed Apr 2 18:50:12 2014 +0200
virsh: Expose virDomain{Get,Set}Time
These APIs are exposed under new virsh command 'domtime' which both gets
and sets (not at the same time of course :)).
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
commit 0abb36938027f3991f3ce5151b31cca9737a1287
Author: Michal Privoznik <mprivozn(a)redhat.com>
Date: Wed Apr 2 18:25:07 2014 +0200
Introduce virDomain{Get,Set}Time APIs
These APIs allow users to get or set time in a domain, which may come
handy if the domain has been resumed just recently and NTP is not
configured or hasn't kicked in yet and the guest is running
something time critical. In addition, NTP may refuse to re-set the clock
if the skew is too big.
In addition, new ACL attribute is introduced 'set_time'.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
commit a4693c76f5beb280869dac9d103ceb632c6c1403
Author: Jiri Denemark <jdenemar(a)redhat.com>
Date: Thu May 15 13:11:12 2014 +0200
qemu: Avoid leak in qemuDomainCheckRemoveOptionalDisk
Coverity complains about event being leaked in
qemuDomainCheckRemoveOptionalDisk. The best fix for it is to remove the
disk directly since we already know its index.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
_______________________________________________
Xen-devel mailing list
Xen-devel(a)lists.xen.org
http://lists.xen.org/xen-devel