Re: [libvirt] [PATCH] testutils: Explicitly name virTestCompare*() arguments
On Wed, 2019-02-20 at 14:06 +0100, Michal Privoznik wrote:
On 2/20/19 1:56 PM, Andrea Bolognani wrote:
> There is barely ever a reason *not* to split changes into smaller,
> independent units; having to write "at the same time" in the commit
> message should be your hint that you're doing it wrong ;)
Let me see, the whole sentence reads as follows:
At the same time, rework virTestCompareToULL a bit so that local
variables are named in the same fashion.
I don't see any problem with that.
Okay, full disclosure: I clearly didn't pay enough attention while
reading the commit message and thought the "at the same time" bit
referred to the VIR_AUTOFREE() conversion. My bad.
The overall point still stands, though.
But okay, I'll send v2 splitting this
tiny patch into even smaller ones :-P
I'll check those out right away :)
--
Andrea Bolognani / Red Hat / Virtualization