Re: [libvirt] [PATCH 3/3] util: Fix fallocate stubs for mingw build

On 12/16/2014 12:13 PM, Martin Kletzander wrote: > When any of the functions modified in commit 214c687b took false branch, > the function itself used none of its parameters resulting in "unused > parameter" error. Rewriting these functions to the stubs we use > elsewhere should fix the problem. > > +#else /* !HAVE_MMAP */ > +static int > +safezero_mmap(int fd ATTRIBUTE_UNUSED, > + off_t offset ATTRIBUTE_UNUSED, > + off_t lenATTRIBUTE_UNUSED) Shoot. I caught (and you corrected) the missing space... > +{ > + return -1 ...but we missed the missing ';', which means this code still won't compile for someone without mmap. I'll push the obvious followup.