Re: [libvirt] [PATCH python] rpm: assume python3 is always available
On Thu, Aug 10, 2017 at 02:01:40PM +0200, Martin Kletzander wrote:
On Thu, Aug 10, 2017 at 12:11:00PM +0100, Daniel P. Berrange wrote:
> On Thu, Aug 10, 2017 at 09:27:27AM +0200, Martin Kletzander wrote:
> > On Wed, Aug 09, 2017 at 05:08:44PM +0100, Daniel P. Berrange wrote:
> > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> > > ---
> > > libvirt-python.spec.in | 17 -----------------
> > > 1 file changed, 17 deletions(-)
> > >
> >
> > Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
> >
> > I think this is reasonable even for CentOS 6
>
> Urgh, no, RHEL 7 has no Python3 by default, so we can't do this. I'm
> going to revert it, and merely change the 0%{?fedora} > 18 check to
> 0%{?fedora}
>
It doesn't have it as default, but if you want to build this package, it
only requires packages that exist, so it's still possible to build this,
right?
Sure you can find a py3 RPM from an optional channel and install it,
but that doesn't fly for main koji / brew builds where you can't just
pull in extra channels to the build root.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|