Re: [libvirt] [PATCH 03/12] domain: add implicit controllers from post parse

Seems like the natural fit, since we are already adding other XML bits in the PostParse routine. Previously AddImplicitControllers was only called at the end of XML parsing, meaning code that builds a DomainDef by hand had to manually call it. Adding it for those sites causes some test suite churn. ---

57 files changed, 59 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2570f94..5b9dab9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3854,6 +3854,9 @@ virDomainDefPostParseInternal(virDomainDefPtr def, if (virDomainDefPostParseTimer(def) < 0) return -1; + if (virDomainDefAddImplicitControllers(def) < 0) + return -1; +

/* clean up possibly duplicated metadata entries */ virDomainDefMetadataSanitize(def);