Re: [libvirt] [PATCH] Avoid closing uninitialized FDs when LXC startup fails

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; If an LXC domain failed to start because of a bogus SELinux label, virLXCProcessStart would call VIR_CLOSE(0) by mistake. This is because the code which initializes the member of the ttyFDs array to -1 got moved too far away from the place where the array is first allocated. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- src/lxc/lxc_process.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

+ for (i = 0 ; i < vm->def->nconsoles ; i++) + ttyFDs[i] = -1;