Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

On Tue, Mar 28, 2017 at 03:22:34PM +0800, Eli Qiao wrote: > hi Martin > > (cc libvir-list) > > I am a little confused about cat support. > > I am currently rebasing my code on top of pre-cat branch from your private github repo, today when I check it you have removed it and create a cat branch and there are some related code pushed[1], can I know what ’s your plan for my patch set for CAT support ? should I continue my rebasing work? your though? So we can work together on that. Since the rework of the sysfs functions, some patches are easier to write from scratch then rewrite, but I'm now just trying to setup the test suite, so that we have something to test on, at least some of the code. So where are you in the rebase right now? Do you think anything from the virsysfs.c code could be enhanced?

> [1] https://github.com/nertpinx/libvirt/commit/c335de47a4efeca87f23e641a93587... > > Thanks Eli. > > > > -- > Best regards > Eli > > 天涯无处不重逢 > a leaf duckweed belongs to the sea, where not to meet in life > > Sent with Sparrow (http://www.sparrowmailapp.com/?sig) > > > On Friday, 24 March 2017 at 3:42 PM, Martin Kletzander wrote: > > > On Fri, Mar 24, 2017 at 09:35:33AM +0800, Eli Qiao wrote: > > > > > > > > > -- > > > Best regards > > > Eli > > > > > > 天涯无处不重逢 > > > a leaf duckweed belongs to the sea, where not to meet in life > > > > > > Sent with Sparrow (http://www.sparrowmailapp.com/?sig) > > > > > > > > > On Thursday, 16 March 2017 at 3:52 PM, Eli Qiao wrote: > > > > > > > > > > > > > > > -- > > > > Best regards > > > > Eli > > > > > > > > 天涯无处不重逢 > > > > a leaf duckweed belongs to the sea, where not to meet in life > > > > > > > > Sent with Sparrow (http://www.sparrowmailapp.com/?sig) > > > > > > > > > > > > On Wednesday, 15 March 2017 at 7:57 PM, Martin Kletzander wrote: > > > > > > > > > On Mon, Mar 06, 2017 at 06:06:30PM +0800, Eli Qiao wrote: > > > > > > This patch adds some utils struct and functions to expose resctrl > > > > > > information. > > > > > > > > > > > > virResCtrlAvailable: if resctrl interface exist on host. > > > > > > virResCtrlGet: get specific type resource control information. > > > > > > virResCtrlInit: initialize resctrl struct from the host's sys fs. > > > > > > resctrlall[]: an array to maintain resource control information. > > > > > > > > > > > > Some of host cpu related information methods was added in virhostcpu.c > > > > > > > > > > So to be able to test all this we need to make a bit different approach. > > > > > I'm not in favour of pushing this without proper tests. Some paths need > > > > > to be configurable, some readings should be unified. Unfortunately lot > > > > > of the code is just copy-paste mess from the past. Fortunately for you, > > > > > > > > > > > > > > > > > > > > I'm working on cleaning this up, at least a little bit, so that we can > > > > > > > > Good news. > > > > > add the tests easily. I got almost up to the test (I stumbled upon few > > > > > rabbit holes on the way and some clean-ups went wrong along the way), so > > > > > it should be pretty easy for you to modify this code to use what I'll be > > > > > proposing to add. It's not ready yet, but you can start rebasing your > > > > > series on top of my branch pre-cat from my github repo [1]. The commits > > > > > are not very well described right now (for some temporary ones I used > > > > > whatthecommit.com (http://whatthecommit.com), sorry), but I'll fix all that. I'll be updating the > > > > > branch, but it will be done with force pushes, so be careful when > > > > > rebasing on top of newer versions. > > > > > > > > > > I can do that if you don't want, just let me know so we can coordinate. > > > > of cause we can do some coordinate, but I am glad that you can help on this to speed up the progress to merge them, as you know this patch is in V10 already, and it has 12 patch set, kinds of hard to doing rebase… :( > > > > > > > > > > > > > Just a quick heads-up, there will be virsysfs that will be used for the > > > > > reads, some additional helper functions in virhostcpu and virfile, test > > > > > that scans copy of /sys/devices/system (with that path faked thanks to > > > > > using the aforementioned virsysfs) and outputs capabilities so that we > > > > > can check the capability XML and so on. > > > > > > > > > > > > > > > > > > > > > > > > > Ah, that’s a good news.. > > > > > > > > > > Martin > > > > > > > > > > [1] https://github.com/nertpinx/libvirt > > > > > > hi Martin > > > > > > So, if I understand you correctly , you want all my patch set to rebased on top of pre-cat branch [1] , I checked that the last commit is 15th March, I wonder if that ’s ready to merged into master? > > > so that I can start doing the rebasing > > > > > > > > > > > I forgot to do the usual push, it's updated now. The test fails in one > > occasion, but it's the code's fault, the test is fine. That's the last > > thing I'm looking at now, after that I'll send it to the list. > > > > Look at the changes and see what you can use, it will help simplifying > > your code a lot, I thing. You can start rebasing on top of that, I'll > > do that as well after it's posted and I'll be either using and modifying > > your patches or maybe doing some myself. > > > > Martin