Re: [libvirt] [PATCHv2] storage_encryption: silence clang warning

Using the cast is the lesser evil ;) >> >> Of course, avoiding casts is good, too, but IMHO, not if >> it makes us obfuscate (even ever so slightly) the types we use. > > Well, the real point of this patch was to silence a compiler warning > (not that we'd ever planning on passing an indent > 2G). Given Dave's > ACK, I went ahead and applied v2 as proposed, even if it does slightly > obfuscate the usage. Warning removal is important. But it can end up being counterproductive if not done carefully.