Re: [libvirt] [PATCH 1/2] virsh: Add option 'model' for attach-interface

On Mon, Oct 25, 2010 at 08:00:23PM +0800, Osier Yang wrote: > Allows to specify the NIC model type when attaching an interface, > it's an optional option. > --- > tools/virsh.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) Okay, though we are in feature freeze I consider this a bug, we forgot to add this option to this command, since this doesn't touch any interface and can't really introduce regressions, I think it's fine to push such a fix now. Patches looks fine too, so I pushed both to git,

thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/