Re: [libvirt] [PATCH] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
On Mon, 2018-04-30 at 16:01 +0100, Maciej Wolny wrote:
This caused an error on Debian, where the tool is called libtoolize,
not
libtool.
Can you please share the specific error message?
libtool and libtoolize are two different programs: the latter is
used to setup a project for using the former, which in turn is
called instead of the compiler and linker during build. AFAICT,
that's both the upstream and downstream behavior, regardless of
distribution.
- $(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
+ $(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
What we might want to do here is call $(top_srcdir)/libtool
instead of plain libtool, so that we run the local copy installed
by libtoolize rather than the vendor-provided one, and we don't
require the user to install libtool at all when building from a
release archive rather than a git checkout.
--
Andrea Bolognani / Red Hat / Virtualization