Re: [libvirt] [PATCH] virsh: Remove redundant optional option for cmdHelp
>
> - name = vshCommandOptString(cmd, "command", NULL);
> -
> - if (!name)
> - name = vshCommandOptString(cmd, "group", NULL);
> + name = vshCommandOptString(cmd, "command-or-group", NULL);
NACK. This breaks backwards compatibility for anyone with scripts already using
"--command":
Don't think anyone really used "--command", our test programs
even doesn't use it.
So then it's reasonable to be consistent, as virsh supports
both command and command group now, and actually I save
you pushed the doc patch.
Regards
- Osier