Re: [libvirt] [PATCHv3 0/2] notify about reverting to a snapshot
On Tue, Jan 05, 2016 at 17:19:19 -0500, John Ferlan wrote:
On 12/23/2015 09:25 AM, Dmitry Andreev wrote:
> Reverting to snapshot may change domain configuration but
> there will be no events about that.
I'm afraid there will be more places like this ...
>
> Lack of the event become a problem for virt-manager
> https://bugzilla.redhat.com/show_bug.cgi?id=1081148
>
> This patch-set introduces new event and emits it in
> qemuDomainRevertToSnapshot.
[...]
>
>
This seems to be a reasonable approach; however, since Peter understands
the snapshot code better than I do, I expect he will want to chime in
(I've CC'd him).
I don't currently see a problem with emiting the event. We indeed
replace the complete definition with something else so a 'DEFINED'
event is probably appropriate.
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)