Re: [libvirt] [PATCH v1 19/31] network_conf: Turn virNetworkObjList into virObject

On 03.03.2015 11:47, Peter Krempa wrote: > On Thu, Feb 26, 2015 at 15:17:28 +0100, Michal Privoznik wrote: >> Well, one day this will be self-locking object, but not today. >> But lets prepare the code for that! Moreover, >> virNetworkObjListFree() is no longer needed, so turn it into >> virNetworkObjListDispose(). >> >> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; >> --- >> cfg.mk | 1 - >> src/conf/network_conf.c | 53 +++++++++++++++++++++++++++++---------- >> src/conf/network_conf.h | 11 ++++---- >> src/libvirt_private.syms | 2 +- >> src/network/bridge_driver.c | 5 ++-- >> src/parallels/parallels_driver.c | 2 +- >> src/parallels/parallels_network.c | 2 +- >> src/test/test_driver.c | 13 ++++------ >> 8 files changed, 56 insertions(+), 33 deletions(-) >> >> diff --git a/cfg.mk b/cfg.mk >> index d72b039..07a794a 100644 >> --- a/cfg.mk >> +++ b/cfg.mk >> @@ -250,7 +250,6 @@ useless_free_options = \ >> # n virNetworkFree (returns int) >> # n virNetworkFreeName (returns int) >> # y virNetworkObjFree >> -# n virNetworkObjListFree FIXME >> # n virNodeDevCapsDefFree FIXME >> # y virNodeDeviceDefFree >> # n virNodeDeviceFree (returns int) >> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c >> index 24a5f7c..4efad43 100644 >> --- a/src/conf/network_conf.c >> +++ b/src/conf/network_conf.c >> @@ -73,17 +73,33 @@ VIR_ENUM_IMPL(virNetworkForwardDriverName, >> VIR_ENUM_IMPL(virNetworkTaint, VIR_NETWORK_TAINT_LAST, >> "hook-script"); >> >> -bool >> -virNetworkObjTaint(virNetworkObjPtr obj, >> - virNetworkTaintFlags taint) > > I don't see a reason to move this function ... I just wanted the class initiatiors to be together. I prefer having it that way.

Michal