Re: [libvirt] [PATCH 4/4] tests: domaincaps: Add QEMU 4.0.0 for s390x

On Fri, 2019-05-03 at 10:47 +0200, Boris Fiuczynski wrote: [...] > +++ b/tests/domaincapstest.c > @@ -453,6 +453,10 @@ mymain(void) > DO_TEST_QEMU("4.0.0", "caps_4.0.0", > "/usr/bin/qemu-system-x86_64", NULL, > "x86_64", VIR_DOMAIN_VIRT_KVM); > + > + DO_TEST_QEMU("4.0.0", "caps_4.0.0", > + "/usr/bin/qemu-system-s390x", NULL, > + "s390x", VIR_DOMAIN_VIRT_KVM); It's pretty annoying that we have to update this test program manually every time new .replies are added. Easy to miss, too, and in fact we seem to only have coverage for about half the possible input files. We should modify this so that dropping .replies into the source directory is enough for the test program to pick them up, just like qemucapabilitiestest and qemucaps2xmltest do. But that's work for another day, so in the meantime Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt;