Re: [libvirt] [PATCH 3/3] gluster: Fix "key" attribute for gluster volumes
On Mon, Feb 24, 2014 at 01:59:30PM -0700, Eric Blake wrote:
On 02/24/2014 08:21 AM, Peter Krempa wrote:
> According to our documentation the "key" value has the following
> meaning: "Providing an identifier for the volume which is globally
> unique. This cannot be set when creating a volume: it is always
> generated." The currently used keys for gluster volumes consist of the
> gluster volume name and file path. This can't be considered unique as a
> different storage server can serve a volume with the same name.
>
> Use the full URI as the key for the volume to avoid ambiguity problems.
The full URI cannot be considered unique, either, as both
gluster://hosta/volume/file and gluster://hostb/volume/file may resolve
to the same file.
You're talking about a different type of uniqueness here. The important
aspect of key uniqueness is that a single 'key' must be unambigous about
what volume it is associated with. ie a single 'key' must not be capable
of refering to 2 completely different volumes. Your example is about
whether each volume has precisely 1 unique key. In the context of the
storage pools I believe only the former point is important.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|