Re: [libvirt] [PATCH 6/6] tests: qemuxml2argv: Test formatting of 'write-cache' parameter

On Wed, Apr 11, 2018 at 11:20:43 -0400, John Ferlan wrote: I can squash this in to the previous patch, but I usually prefer having them separate when we are adding a lot of new lines. I don't think a XML2XML test is necessary here. This feature is not using any new XML configuration, but rather uses existing values to express the new configuration. Well, given that prior to the ability to test it with real capabilities, we'd test it with a configuration which would not exist by listing the required capability bits in the surce file, the same would apply. As said above. That's originating from the fact that our previous testing sucked and did not really compare to anything real-life. If I'd were to add a DO_TEST case using the capability explicitly the tests would not change in the same way as they did not change here, so the version used for capabilities does not really matter in any way here. I can shuffle them around if you want. But it then can't be merged with previous patch. Also until the feature is implemented, the test will not test what it is declaring to test.