Re: [libvirt] [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser

Ian Jackson writes ("[OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser"): > Do not grep the virsh capabilities output (!) Instead, parse the XML > using perl's XML modules and look for the specific feature flag using > an XPATH pattern. ...> > +sub _check_capability ($$) { ... > + $rc = $self->check_capability('/capabilities/host/migration_features'); ^ Missing _. I didn't test this again before sending it. I'd still like a review from libvirt (and Xen/ARM) folks.