Re: [PATCH 1/9] util: storagefile: Drop image format probing by file suffix

Probing by file suffix was meant to be a last resort if probing by contents fails or is not supported. For most formats we never specified any suffix. There's a few formats implementing both magic bytes and suffix and finally DMG which had only suffix probing. Since suffix probing is nowhere reliable and only one format depends on in whic has a

comment that qemu doesn't do the probing either drop the whole infrastructure. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; --- src/util/virstoragefile.c | 58 ++++++++++++--------------------------- 1 file changed, 17 insertions(+), 41 deletions(-)

@@ -324,50 +322,50 @@ static struct FileTypeInfo const fileTypeInfo[] = { /* XXX QEMU says there's no magic for dmg, * /usr/share/misc/magic lists double magic (both offsets * would have to match) but then disables that check. */ - 0, NULL, ".dmg", + 0, NULL, 0, -1, 0, {0}, -1, 0, 0, NULL, NULL, NULL },