Re: [libvirt PATCH 5/6] nodedev: add mdev support to virNodeDeviceCreateXML()

On 4/30/20 11:42 PM, Jonathon Jongsma wrote: > With recent additions to the node device xml schema, an xml schema can > now describe a mdev device sufficiently for libvirt to create and start > the device using the mdevctl utility. > > Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com&gt; > --- > libvirt.spec.in | 3 + > m4/virt-external-programs.m4 | 3 + > src/conf/virnodedeviceobj.c | 34 +++++ > src/conf/virnodedeviceobj.h | 3 + > src/libvirt_private.syms | 1 + > src/node_device/node_device_driver.c | 177 +++++++++++++++++++++++++++ > 6 files changed, 221 insertions(+) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 6abf97df85..411846a9fc 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -466,6 +466,9 @@ Requires: dbus > # For uid creation during pre > Requires(pre): shadow-utils > +# For managing persistent mediated devices > +Recommends: mdevctl > + I wonder whether we could make this for nodedev driver RPM only. Because, if somebody installs say client library + virsh only (for remote mgmt), then there is no reason they should install mdevctl with that.