Re: [libvirt PATCH] qemu: Support vmpvscsi controller model
On Fri, May 08, 2020 at 19:02:21 -0400, Chris Jester-Young wrote:
It would be great if you could describe that 'pvscsi' indeed is the
vmware paravirtual scsi controller even in qemu, because I had to dig
through the code to figure it out.
Signed-off-by: Chris Jester-Young <cky(a)cky.nz>
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 4 +++-
src/qemu/qemu_validate.c | 9 ++++++++-
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 +
Can the 'pvscsi' device be compiled out using any upstream way? If not
we don't really need a capability for it since qemu-1.5.3 is the oldest
supported qemu and all other versions support it as well.
[...]
The remainder of the patch looks okay to me, but it's missing a
qemuxml2argvtest case for the new controller. It looks like the
controller is using PCI addressing so the rest should be okay.
If you figure out that the capability is required, I'd prefer if the
addition of the capability is in a separate patch.