On 2021/8/20 18:18, Cornelia Huck wrote:
On Fri, Aug 20 2021, Yanan Wang <wangyanan55(a)huawei.com>
wrote:
> Unify the subject format in deprecated.rst to "since X.Y".
> Unify the subject format in removed-features.rst to "removed in X.Y".
It seems unlikely that we will ever deprecate something in a stable
release, and even more unlikely that we'll remove something in one, so
the short versions look like the thing we want to standardize on.
> Signed-off-by: Yanan Wang <wangyanan55(a)huawei.com>
> ---
> docs/about/deprecated.rst | 56 ++++++++++++++++-----------------
> docs/about/removed-features.rst | 28 ++++++++---------
> 2 files changed, 42 insertions(+), 42 deletions(-)
Unrelated to your patch, line 143 in removed-features.rst reads
``-vnc ...,tls=...``, ``-vnc ...,x509=...`` & ``-vnc ...,x509verify=...``
and is missing the release it was removed in (presumably 3.1?)
Yes, this part of
section was introduced by commit 29e0447551
(docs/about/removed-features: Document removed CLI options from QEMU v3.1),
so I think a record of "removed in 3.1" is needed. I rechecked both
deprecated.rst
and removed-features.rst, and this is the only place where we are
missing a release.
I can fix this in a third patch.
Anyway,
Reviewed-by: Cornelia Huck <cohuck(a)redhat.com>
.
Thanks,
Yanan