Re: [libvirt] [PATCH] libvirt.spec patch to fix some rpmlint warnings/errors
On Wed, Feb 11, 2009 at 05:33:56PM +0000, Richard W.M. Jones wrote:
On Wed, Feb 11, 2009 at 05:25:23PM +0000, Daniel P. Berrange wrote:
> > I'm not sure about the patch to libvirt.init.in, but rpmlint is quite
> > insistent that we need this, or else we shouldn't start libvirtd by
> > default.
>
> rpmlint is dumb. If we turn it off by default, then we'll just get a
> steady stream of bugs / confused users, who install libvirt RPM (or
> the "Virtualization Group" in installer), reboot and find it is not
> working because the daemon wasn't started. This would be a disservice
> to our users, which I don't think we should do
Maybe you (or I) misunderstand the change to libvirtd.init.in.
Supposedly this change should keep it on by default, AND silence
rpmlint as well.
My understanding is that when we do 'chkconfig --add libvirtd' in the
%post section, it loooks at these magic headers we have:
# Default-Start: 3 4 5
# chkconfig: 345 97 03
If there is no 'Default-Start', and the first 'chkconfig'field is
'-'
# chkconfig: - 97 03
then all the initial symlinks in /etc/rc.d/rcX.d will be disabled.
So immediately after RPM install, it won't be configured to start
on boot, and the user would need to menually run to turn it on
chkconfig libvirtd on
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|