Re: [libvirt] [PATCH 4/6] conf: Move virDomainPCIAddressAsString() to device_conf
On Fri, 2018-08-31 at 15:29 +0100, Daniel P. Berrangé wrote:
On Fri, Aug 31, 2018 at 04:25:25PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-08-31 at 15:05 +0100, Daniel P. Berrangé wrote:
> > This should really be in src/util/virpci.{c,h}, since that's where the
> > virPCIDeviceAddressPtr struct is declared. There's nothing XML related
> > about this string conversion, so doesn't belong in src/conf at all.
>
> See the commit message :)
>
> I can move this to util/virpci instead of conf/device_conf for
> the time being if you prefer, but at some point we're going to
> have to pick a place for *all* functions related to PCI addresses
> and conf/device_conf is the most sensible option IMHO, seeing as
> all other address types and related functions are defined there.
The device_conf file is dealing with domain device addresses. The
virPCIDeviceAddressPtr struct is independant of domain device
addresses. It is used across domain, node device, network and
storage drivers.
Yeah, it's a mess. I'll move it to util/virpci instead, but that
won't make the mess go away :)
--
Andrea Bolognani / Red Hat / Virtualization