Re: [libvirt] [libvirt-glib 03/10] Add GObject boilerplate for GVirConfigStorage*

On Wed, Dec 14, 2011 at 02:51:33PM +0000, Daniel P. Berrange wrote: > On Tue, Dec 06, 2011 at 04:00:52PM +0100, Christophe Fergeau wrote: > > We'll need several helper classes to implement configuration of > > storage pools and volumes. This commit introduces all of these > > in one go. It's just the GObject boilerplate, the actual code will > > come in other commits. GVirConfigStoragePermissions is namespaced this > > way because it will be used by both GVirConfigStoragePoolTarget and > > GVirConfigStorageVolTarget. > > --- > > libvirt-gconfig/Makefile.am | 12 +++- > > .../libvirt-gconfig-storage-permissions.c | 70 +++++++++++++++++++ > > .../libvirt-gconfig-storage-permissions.h | 68 ++++++++++++++++++ > > .../libvirt-gconfig-storage-pool-source.c | 72 ++++++++++++++++++++ > > .../libvirt-gconfig-storage-pool-source.h | 68 ++++++++++++++++++ > > .../libvirt-gconfig-storage-pool-target.c | 72 ++++++++++++++++++++ > > .../libvirt-gconfig-storage-pool-target.h | 68 ++++++++++++++++++ > > .../libvirt-gconfig-storage-vol-backing-store.c | 72 ++++++++++++++++++++ > > .../libvirt-gconfig-storage-vol-backing-store.h | 68 ++++++++++++++++++ > > .../libvirt-gconfig-storage-vol-target.c | 72 ++++++++++++++++++++ > > .../libvirt-gconfig-storage-vol-target.h | 68 ++++++++++++++++++ > > The storage volume <backingStore> element is really a subset of the > storage volume <target> element schema, so there is perhaps value > in having a shared parent class between them I'm not sure this would bring much, except if these 2 nodes grow a lot of new attributes. I'd tend to commit this as is for now, and maybe improve it later if this proves worth it. IS it fine with you, or do you prefer to have this done now?