Re: [libvirt] [PATCH 8/8] Extend the ACL test case to validate filter rule checks
On Tue, Jul 02, 2013 at 04:21:30PM -0600, Eric Blake wrote:
On 06/27/2013 10:57 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> The 'check-aclrules' test case validates that there are ACL
> checks in each method. This extends it so that it can also
> validate that methods which return info about lists of objects,
> will filter their returned info throw an ACL check.
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> src/Makefile.am | 1 +
> src/check-aclrules.pl | 97 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 98 insertions(+)
>
Seems reasonable; my perl is not as strong as my C, but it looks like
you were able to apply this patch out of order to test that it worked
correctly. ACK.
Yes, exactly. I wrote this test case first, and then fixed up all the
flaws it identified.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|