Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: > The check for a single display remains so no new functionality is > added. > --- > > Concerning both patches, I've tested running with all three > simultaneously (sdl+spice+vnc) and with spice+vnc, using a > single qxl device. > > src/qemu/qemu_command.c | 2425 > ++++++++++++++++++++++++----------------------- > src/qemu/qemu_process.c | 70 +- > 2 files changed, 1259 insertions(+), 1236 deletions(-) I'm not really sure what has happened here, but you have got an absolutely enourmous diff here. I would expect this patch to only affect the small part of qemuBuildCommandLine that actually deals with graphics devices. As it is now, it is impossible to review this patch I'm afraid :-(

Daniel -- |: http://berrange.com -o- | http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- | http://virt-manager.org :| |: http://autobuild.org -o- | http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- | http://live.gnome.org/gtk-vnc :|