Re: [libvirt] [Qemu-devel] [PATCH] virtio-rng: correct the default limit rate

Il 26/11/2013 14:43, Amos Kong ha scritto: > /* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If > * you have an entropy source capable of generating more entropy than this > * and you can pass it through via virtio-rng, then hats off to you. Until > * then, this is unlimited for all practical purposes. > */ > > But the current rate is (INT64_MAX) bytes per (1 << 16) ms, it's 128,000 TB/s You are changing: * max-bytes from 2^63 to 2^47 * period from 65536 to 60000 For a user, changing only period would have no effect, the limit rate would remain effectively infinite. Changing max-bytes would give a 7% higher rate after your patch. Not a big deal, and max-bytes is easier to explain after your patch (bytes/minute) than before (bytes/65536ms). Reviewed-by: Paolo Bonzini <pbonzini(a)redhat.com&gt;