Re: [libvirt] [PATCH] Removed function virDomainDefNewFull.

On 05/30/2016 04:21 AM, Ján Tomko wrote: I'm guessing it came from: http://wiki.libvirt.org/page/BiteSizedTasks#Remove_virDomainDefNewFull.28.29 I added that entry. My motivation was that the function doesn't add much: just saves a small amount of code total, while adding to the already quite large domain_conf.c internal API. The name is DefNewFull is a little weird... it's not all that 'Full', just tracks the metadata bits. Plus outside of the vz usage it's largely about facilitating a pattern in the xen code to use the virDomainDefPtr as a structure to pass around (name, uuid, id) and nothing else, which I find weird. grep for 'minidef' in xen_driver.c for examples of how the code tries to document that distinction. I'd rather see that pattern go away, or the function made private to xen code, than to facilitate it with common code. All that that said this is minor and it was largely just an idea for the BiteSizedTasks page, so if the above doesn't convince feel free to remove that task item from the wiki :) Thanks, Cole