Re: [libvirt] [PATCH] parallels: better support of volume based disks in containers
01.06.2015 12:25, Martin Kletzander пишет:
On Fri, May 29, 2015 at 07:10:28PM +0300, Maxim Nestratov wrote:
> It is possible to attach volumes to containers but since they are
> added they are reported erroneously as filesystems. It is fixed
> in this patch. And as soon as bus type has no meaning for containers
> we always report SATA for such disks.
> In case a container is created with the only disk based on physical
> volume we are expected to specify mount point to be able to boot
> from it, that is done in the patch.
>
> Sygned-off-by: Maxim Nestratov <mnestratov(a)parallels.com>
You can use parameter '-s' of 'git commit', that won't make mistakes
such as this one.
Looks like it is really a better way to do this.
> ---
> .gnulib | 2 +-
> src/parallels/parallels_sdk.c | 40
> +++++++++++++++++++++++++++++++---------
> 2 files changed, 32 insertions(+), 10 deletions(-)
>
> diff --git a/.gnulib b/.gnulib
> index 875ec93..106a386 160000
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit 875ec93e1501d2d2a8bab1b64fa66b8ceb51dc67
> +Subproject commit 106a3866d01f9dd57ab4f10dbeb0d5a8db73a9f7
Looks like you forgot to do 'git submodule update' before commit.
This should not be part of the patch.
Sure this wasn't intended to be in the commit.
Other than that it looks fine to me, although I'm not the proper
oe to
comment on prlSDK usage.
Thank you.
Martin