Re: [libvirt] [PATCH 03/20] drivers: prefer unsigned int for flags

On 07/06/2011 09:07 PM, Daniel Veillard wrote: > On Wed, Jul 06, 2011 at 05:23:46PM -0600, Eric Blake wrote: >> Now that the public APIs always use unsigned flags, the internal >> driver callbacks might as well do likewise. >> >>  struct remote_nwfilter_get_xml_desc_args { >>          remote_nonnull_nwfilter    nwfilter; >> -        int                        flags; >> +        u_int                      flags; >>  }; >>  struct remote_nwfilter_get_xml_desc_ret { >>          remote_nonnull_string      xml; > >   Can we triple check that the remote stuff really allocate the same > space for int and u_int, that's my only doubt in that change, We've done that exact type of change before - see commit 1ff2b6f. > >   ACK, I've pushed 1-5, and am slowly working on rebasing the remaining patches to deal with Matthias' observation about read-only connections (my debugging session proved that we _do_ pass a flag to all the driver open functions).