Re: [libvirt] [v5 PATCH] qemu: call usb search function for hostdev initialization and hotplug

On 05/06/2012 08:55 AM, Guannan Ren wrote: > src/qemu/qemu_hostdev.c: > refactor qemuPrepareHostdevUSBDevices function, make it focus on > adding usb device to activeUsbHostdevs after check. After that, > the usb hotplug function qemuDomainAttachHostDevice also could use > it. > expand qemuPrepareHostUSBDevices to perform the usb search, > rollback on failure. > > src/qemu/qemu_hotplug.c: > If there are multiple usb devices available with same vendorID and productID, > but with different value of "bus, device", we give an error to let user > use<address> to specify the desired one. > --- > src/qemu/qemu_hostdev.c | 120 ++++++++++++++++++++++++++++------------------- > src/qemu/qemu_hostdev.h | 3 +- > src/qemu/qemu_hotplug.c | 69 +++++++++++++++++++-------- > 3 files changed, 122 insertions(+), 70 deletions(-) ACK; this fixes my concerns.