Re: [libvirt] [PATCH] virerror: Make error reporting prettier
On Mon, 2019-04-01 at 09:52 -0400, Laine Stump wrote:
On 4/1/19 6:11 AM, Andrea Bolognani wrote:
> NACK until the list of excuses has been proven to only contain
> grammatically valid and correctly spelled English sentences.
Assuming a lack of commit access to that list, maybe a post-processor
function in libvirt to correct the mistakes would be sufficient?
Fixing mistakes after the fact would open up the possibility of
mistakes slipping through because the list has been updated but our
filter has not caught up with the changes yet. I don't consider that
to be acceptable.
Now, if we had a local copy of the list, possibly handled as a git
submodule, and we used that as a source for the error messages, that
would work... Thought we'd have to make sure the list is available
under a license which is compatible with our own LGPL 2.1+ first.
--
Andrea Bolognani / Red Hat / Virtualization