Re: [libvirt] [PATCH 9/9] qemu: command: Refactor disk commandline formatting
On Fri, Jun 01, 2018 at 05:51:12PM +0200, Peter Krempa wrote:
Now that we have one place that sets up all disk-related objects to
qemuBlockStorageSourceAttachDataPtr we can easily reuse the data in the
command-line formatter by implementing a worker which will convert the
data.
A huge advantage is that it will be way easier to integrate this with
-blockdev later on.
Sadly, I might not live long enough to see that.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_command.c | 94 +++++++++++++++++++------------------------------
src/qemu/qemu_command.h | 3 +-
src/qemu/qemu_hotplug.c | 3 +-
3 files changed, 40 insertions(+), 60 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)