Re: [libvirt] [libvirt-php 0/3] small improvements
Le 18/03/2016 12:51, Vasiliy Tolstov a écrit :
2016-03-07 18:40 GMT+03:00 Vasiliy Tolstov
<v.tolstov(a)selfip.ru>:
> Add some more libvirt functions support to binding.
> Also add some checks to prevent malloc SIZE_MAX memory
> in case of errors
>
> Vasiliy Tolstov (3):
> add some checks to prevent overflow
> add block_commit support and needed const
> add libvirt_domain_block_job_info
>
> src/libvirt-php.c | 152 ++++++++++++++++++++++++++++++++++++++++++++++++------
> src/libvirt-php.h | 2 +
> 2 files changed, 138 insertions(+), 16 deletions(-)
Ping....
I have abolutely no idea what going with libvirt-php,
but FYI I have start a fork which is mostly ready and work with both PHP
5 and 7
If your patch is applied, sources will diverged, and it will be
nightmare to update the fork.
Perhaps you can open a pull request against the fork, so we'll have a
single branch to merged upstream ?
Your patch looks fine to me.
Excepted missing:
- arginfo
- php 7 compat (using strsize_t and zend_long)
Remi
P.S.